feat: Rudementary inline cell editing as a library function #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement simple cell editing that edits the record from the datatable data in place. Provide the onEdit callback to allow hooking external logic to the featureset. This is mostly a small version of the grander feature as has been discussed at length in some issues where a workaround was suggested to use the render function of the column. However, this appears to be very cumbersome to do and maintain. In this case, I belive that I speak for others too, that this may be a good core feature of the datatable with room for expansion in the future.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement simple cell editing that edits the record from the datatable data in place. Provide the onEdit callback to allow hooking external logic to the featureset.
This is mostly a small version of the grander feature as has been discussed at length in some issues where a workaround was suggested to use the render function of the column. However, this appears to be very cumbersome to do and maintain. In this case, I belive that I speak for others too, that this may be a good core feature of the datatable with room for expansion in the future.
This addresses the issue #610 but I don't believe this would close it fully.
I wonder what else there may be that is missing for the first iteration/basic version of this featureset.
Let me know and I'll try to make some time to implement or fix anything new.
I have added an example page to demonstrate it with the basic implementation, this is insipired by but not really the same thing as my provided snippet in the linked issue.